[OpenBIOS] Incorrect implementation of b?branch?
Blue Swirl
blauwirbel at gmail.com
Fri Feb 27 21:07:21 CET 2009
On 2/27/09, Mark Cave-Ayland <mark.cave-ayland at siriusit.co.uk> wrote:
> Blue Swirl wrote:
>
>
> > Basically looks OK to my untrained eyes, except I wonder if there are
> > sign extension functions in Forth.
> >
>
> Thanks for the review. The nearest things I can find are in section 7.3.2.4
> of forth/bootstrap/bootstrap.fs, but these are clearly just byte-swapping
> words.
OK, then the patch is about optimal.
> I'm reasonably confident that it's safe to apply as its quite a small
> contained patch. However it may be worth someone with more Forth experience
> casting a quick eye over it to make sure I haven't done something too
> stupid...
I'm not suspecting of any problems either. I'll apply the patch,
thanks for your patience.
More information about the OpenBIOS
mailing list