[OpenBIOS] [PATCH 3/3] Don't assume that pointer and cell size are identical

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Mon Oct 18 13:28:15 CEST 2010


Andreas Färber wrote:

>  Hey,
>  
>  I've compile-tested ppc, ppc64, sparc32, sparc64; they all appeared to boot
>  as before now (Haiku, AIX, Debian, Solaris, Milax guests).

That's a good sign :)  I'm happy with the patch in principle, but 
probably Blue/Alex should have the main say on this one.

>  @Mark: I've taken the liberty of using push_str() in ofmem_set_property()
>  to avoid duplicating the conversion.

Ah yes, good spot. I'll leave it as it is at the moment so it won't 
interfere with your patchset.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs



More information about the OpenBIOS mailing list