[OpenBIOS] [PATCH 3/3] Don't assume that pointer and cell size are identical

[Blue Swirl]

On Wed, Oct 20, 2010 at 8:04 AM, Alexander Graf <agraf at suse.de> wrote:
>
> On 18.10.2010, at 13:28, Mark Cave-Ayland wrote:
>
>> Andreas Färber wrote:
>>
>>> Hey,
>>>  I've compile-tested ppc, ppc64, sparc32, sparc64; they all appeared to boot
>>> as before now (Haiku, AIX, Debian, Solaris, Milax guests).
>>
>> That's a good sign :)  I'm happy with the patch in principle, but probably Blue/Alex should have the main say on this one.
>
> The changes look pretty mechanical, so I don't think there's too much chance to break things. What we really need is a set of test images + cases to verify that everything still works. Preferably automated far enough to run automatically after every commit for easy bisecting.

I tried to use kvm-autotest for Sparc, it sort of worked but it was a
bit heavyweight. If someone has a server farm to run the tests, that
could be a good approach.

> Also, looking at the amount of work Andreas is putting into OpenBIOS atm, wouldn't it make sense to give him commit rights? Larger changes could still go through RFC cycles, but for mechanical parts I'm not sure the peer review is all that helpful.

He should probably discuss about that with Stefan.