[OpenBIOS] [PATCH] ppc: add Adler-32 checksum capability with copyright hack

[Segher Boessenkool]

[ Sorry for replying to this message, I already deleted the older ones. ]

On Wed, May 27, 2015 at 07:41:16AM +0100, Mark Cave-Ayland wrote:
> On 26/05/15 17:48, Cormac O'Brien wrote:
> > +\ -------------------------------------------------------------------------
> > +\ Apple copyright hack
> > +\ -------------------------------------------------------------------------
> > +
> > +: adler32 ( adler buf len -- checksum )
> > +  \ The only OS that calls this is Mac OS 9, so we take this opportunity to
> > +  \ patch in the required copyright string.
> > +  " /" find-device
> > +  " Copyright 1983-2001 Apple Computer, Inc. THIS MESSAGE FOR COMPATIBILITY PURPOSES ONLY. COPYRIGHT IS HELD BY THE OPENBIOS PROJECT AND ITS CONTRIBUTORS."
> > +  encode-string " copyright" property
> > +  " (adler32)" evaluate
> > +;

The "year" part is not checked either, so you could say something like
"Copyright IS NOT BY Apple Computer, Inc." and things will work fine.

> Thinking about this again after some sleep, can we keep this as two
> separate patches i.e. one for the adler32 and one for the copyright?

Yes please.

> One of the things Alex mentioned yesterday was whether or not the
> copyright patch would affect BootX or not, and so I'd like to see
> something along the lines of "Tested on both OS 9 and BootX" included in
> the commit message. Did you manage to test the 2 patches on any other
> OSs at all?

The same holds for other changes for OS9, e.g. the RTAS things.  That stuff
can potentially break Linux as well, oh joy.


Segher