[OpenBIOS] [PATCH] libopenbios/bootinfo_load.c: Implement Mac OS 9.2 boot script support

[Mark Cave-Ayland]

On 27/04/16 11:14, BALATON Zoltan wrote:

> On Tue, 26 Apr 2016, Programmingkid wrote:
>> On Apr 26, 2016, at 4:11 PM, BALATON Zoltan wrote:
>>> On Tue, 26 Apr 2016, Programmingkid wrote:
>>>> This patch makes booting Mac OS 9.2 possible. It replaces all
>>>> occurrences of
>>>>> r and r> with sub_>r and sub_r>. This allows for the return stack
>>>>> to be left
>>>> alone.
>>>
>>> Can we have Segher's Forth version of this instead:
>>>
>>> https://www.coreboot.org/pipermail/openbios/2016-April/009338.html
>>>
>>> That should be equivalent and would make the C code much simpler and
>>> allow dropping most of these patches.
>>
>> That code doesn't work. It causes a "Dictionary space overflow" message
>> to be printed. My code does work.
> 
> Maybe you need to increase the available cells to have enough space? I
> don't know much about Forth to understand the code better.

I think Segher's version is closer to what we are trying to achieve -
there is a lot of extra code added for something where the end result
isn't excessively context. Can you find out with the Forth debugger
exactly why Segher's patch is failing?


ATB,

Mark.