<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 19, 2015, at 3:52 PM, Cormac O'Brien wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>This patch provides a more memory-efficient method of allocating memory for the<br>boot script by using the actual script length (including entity translations)<br>instead of the file size.<br><br>Signed-off-by: Cormac O'Brien <<a href="mailto:i.am.cormac.obrien@gmail.com">i.am.cormac.obrien@gmail.com</a>><br><br>---<br> libopenbios/bootinfo_load.c | 102 +++++++++++++++++++++++++++++---------------<br> 1 file changed, 67 insertions(+), 35 deletions(-)<br><br>diff --git a/libopenbios/bootinfo_load.c b/libopenbios/bootinfo_load.c<br>index fa9e36b..bd282f4 100644<br>--- a/libopenbios/bootinfo_load.c<br>+++ b/libopenbios/bootinfo_load.c<br>@@ -20,7 +20,7 @@<br> #include "libopenbios/ofmem.h"<br> #include "libc/vsprintf.h"<br><br>-//#define DEBUG_BOOTINFO<br>+#define DEBUG_BOOTINFO<br></div></blockquote><div><br></div><div>Your patch applied easily for me and it did work. The only problem I found is the</div><div>uncommented DEBUG_BOOTINFO macro. I am betting Mark would like to keep</div><div>it commented.</div><div><br></div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font>+<br> <span class="Apple-tab-span" style="white-space:pre"> </span>/* If the payload is bootinfo then we execute it immediately */<br> <span class="Apple-tab-span" style="white-space:pre"> </span>if (scriptvalid) {<br> <span class="Apple-tab-span" style="white-space:pre"> </span><span class="Apple-tab-span" style="white-space:pre"> </span>DPRINTF("bootscript: %s\n", bootscript);<br></div></blockquote><br></div><div>Is this about where you placed your '\r'->'\n' hack? Could you please send me it?</div></body></html>