[OpenBIOS] [PATCH] herewrite: check for dictionary overflow

Igor Kovalenko igor.v.kovalenko at gmail.com
Mon Apr 12 22:17:30 CEST 2010


On Mon, Apr 12, 2010 at 2:15 PM, Mark Cave-Ayland
<mark.cave-ayland at siriusit.co.uk> wrote:
> Igor V. Kovalenko wrote:
>
>> From: Igor V. Kovalenko <igor.v.kovalenko at gmail.com>
>>
>> - add dictlimit variable to store dictionary memory size
>> - change herewrite() to check for overflow if dictlimit is set
>> - sparc64: set dictlimit to allocated amount
>
> This patch looks great in that it correctly picks up on the overflow
> condition when added to r740. If you could update it so that it works on all
> archs then I'm happy to apply it.

I was looking at hiding dict and dictlimit assignment behind
initialization routine
but it is not a priority task now that you applied modified version :)

-- 
Kind regards,
Igor V. Kovalenko



More information about the OpenBIOS mailing list