[OpenBIOS] [RFC] libopenbios: Adapt CIF handling for ppc64

Mark Cave-Ayland mark.cave-ayland at siriusit.co.uk
Mon Dec 20 20:01:43 CET 2010


Blue Swirl wrote:

>> +#ifdef CONFIG_PPC64
>> +typedef int             prom_arg_t;
>> +typedef unsigned int    prom_uarg_t;
>> +#define PRIdARG "d"
>> +#define PRIxARG "x"
>> +#define FMT_arg  "%" PRIdARG
>> +#define FMT_argx "%08" PRIxARG
>> +#else
>> +typedef long            prom_arg_t;
>> +typedef unsigned long   prom_uarg_t;
>> +#define PRIdARG "ld"
>> +#define PRIxARG "lx"
>> +#define FMT_arg  "%" PRIdARG
>> +#define FMT_argx "%08" PRIxARG
> 
> This should be "%016" for Sparc64 since long is 64 bits. Maybe these
> should be moved to a common header instead.

Yeah - I'd like to try and keep all of the format definitions in one 
place, such as include/arch/<arch>/types.h if possible.


ATB,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs



More information about the OpenBIOS mailing list