[OpenBIOS] [PATCH] ESP : Fix SCSI READ command length
Mark Cave-Ayland
mark.cave-ayland at siriusit.co.uk
Fri Jan 28 11:24:42 CET 2011
On 27/01/11 19:05, Olivier DANET wrote:
> Signed-off-by: Olivier Danet<odanet at caramail.com>
> ---
> diff -rup a/drivers/esp.c b/drivers/esp.c
> --- a/drivers/esp.c 2011-01-27 15:11:52.000000000 +0100
> +++ b/drivers/esp.c 2011-01-27 15:13:34.000000000 +0100
> @@ -147,7 +147,7 @@ ob_sd_read_sector(esp_private_t *esp, sd
> sd->id, offset);
>
> // Setup command = Read(10)
> - memset(esp->buffer, 0, 10);
> + memset(esp->buffer, 0, 11);
> esp->buffer[0] = 0x80;
> esp->buffer[1] = READ_10;
>
> @@ -159,7 +159,7 @@ ob_sd_read_sector(esp_private_t *esp, sd
> esp->buffer[8] = 0;
> esp->buffer[9] = 1;
>
> - if (do_command(esp, sd, 10, sd->bs))
> + if (do_command(esp, sd, 11, sd->bs))
> return 0;
>
> return 0;
Hi Olivier,
While on the surface the patch looks sensible, it's quite difficult to
review this (and your associated QEMU patches) in their current form.
Could you re-submit with an extra description, describing briefly i)
what symptoms did you see without the patch, ii) what does this fix with
the patch applied, and iii) a document reference which verifies the
command length should be 11 instead of 10.
ATB,
Mark.
--
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063
Sirius Labs: http://www.siriusit.co.uk/labs
More information about the OpenBIOS
mailing list