[OpenBIOS] [PATCH] Adds filll (3 l's) to dictionary

Programmingkid programmingkidx at gmail.com
Mon Dec 3 22:05:05 CET 2012


On Dec 3, 2012, at 3:54 PM, Mark Cave-Ayland wrote:

>> 
>> +   for(x = 0; x<= length; x++)
>> +   {
>> +      location[x] = fillNumber;
>> +   }
> 
> Compare the formatting of your for() statement above with the others in the file - you should use the existing style in your patch.

I was never a fan of that style, but ok. 


> Also as per my comment on your last version of the patch, you need to use target_long() as per the existing code in lstore.

Do you mean write_long()? This is what lstore uses. Why use this function as oppose to the code I have now?


More information about the OpenBIOS mailing list