[OpenBIOS] [PATCH] Fix mac label whole partition case

Tarl Neustaedter tarl-b2 at tarl.net
Sat Feb 23 23:46:48 CET 2013


On 2013-Feb-23 17:42 , Mark Cave-Ayland wrote:
>
>> Aren't there parens missing? I.e., shouldn't that be ((str == NULL) ||
>> (parnum == 0))?
>
> Not as far as I know unless there is a compiler issue? The C operator 
> precedence table looks like this: 
> http://www.difranco.net/compsci/C_Operator_Precedence_Table.htm.

You can see my inherent trust in compiler writers showing...

If you're still having a problem with optimization doing something 
strange, I'd try the parens. Either that or look at whether the test 
really should be str == NULL (is there an uninitialized path in there?). 
Regards,
     Tarl




More information about the OpenBIOS mailing list