[OpenBIOS] [PATCH] drivers/pci: Recognise RTL8139 network card and enable bus mastering

[BALATON Zoltan]

On Wed, 25 Jun 2014, Mark Cave-Ayland wrote:
> On 25/06/14 22:16, Alexander Graf wrote:
>
>> On 03.06.14 01:34, BALATON Zoltan wrote:
>>> Apart from the older NE2000 card also recognise RTL8139 and set bus
>>> master bit for it. This makes it work in MorphOS which uses it in a
>>> different (DMA) mode than the Linux driver.
>>> 
>>> Signed-off-by: BALATON Zoltan <balaton at eik.bme.hu>
>> 
>> Please create a helper that tells you whether it's safe to enable bus
>> mastering (why doesn't MorphOS do this itself?) on a particular harware
>> platform. Check for that every time you want to enable bus mastering.
>> 
>> static bool should_enable_bus_mastering(void)
>> {
>> #ifdef IS_QEMU_ON_PPC
>>      return true;
>> #else
>>      return false;
>> #endif
>> }
>
> Yeah. We're definitely overdue a CONFIG_QEMU or similar option across all 
> architectures into which we can hide the sins of emulation ;)

I'll send a version shortly with some #if defined(CONFIG_QEMU) around 
enabling bus mastering for both patches. It's probably better than a 
follow up.

Regards,
BALATON Zoltan