[OpenBIOS] [PATCH] add copyright message to root node at startup
Mark Cave-Ayland
mark.cave-ayland at ilande.co.uk
Fri Feb 5 16:18:14 CET 2016
On 05/02/16 15:09, Programmingkid wrote:
> On Feb 5, 2016, at 10:04 AM, Alyssa Milburn wrote:
>
>> On Fri, Feb 05, 2016 at 09:49:37AM -0500, Programmingkid wrote:
>>>> The Beige G3 doesn't have a copyright string in OF, so this seems silly (if
>>>> we eventually add some hack to boot via OF anyway, then we could always add
>>>> it then).
>>>
>>> Are you sure the Beige G3 doesn't have a copyright string?
>>
>> Well, I did 'dev /' and '.properties' and it doesn't list one. I'm not too
>> surprised, since boot-device is the Toolbox ROM, so there was no code which
>> would need to check for one.
>
> Ok, I will send another patch that removes the add_copyright() from the ARCH_HEATHROW case.
>
> Thank you.
I've been thinking about this a bit more when looking over your patch
and have come to following conclusions:
- I think the obfuscation is reasonable, but after more thought I think
ROT13 is a better bet (easier to work with, symmetrical)
- I'd prefer as much of this to be in Forth as possible; many previous
issues with OpenBIOS were caused by the Forth/C divide
- I don't think it matters so much if an extra property is there for
g3beige; things are much more likely to blow up if a property isn't there
- The patch still leaves the copyright property visible before boot
Possibly I may have another similarly over-engineered solution to this;
let me see if I can rustle up something.
ATB,
Mark.
More information about the OpenBIOS
mailing list