[OpenBIOS] [PATCH 0/7] ppc: improve fake copyright message handling

[Mark Cave-Ayland]

On 12/02/16 20:47, Mark Cave-Ayland wrote:

> On 11/02/16 07:51, Alyssa Milburn wrote:
> 
>> On Sat, Feb 06, 2016 at 10:40:10AM +0000, Mark Cave-Ayland wrote:
>>>> This means it is available in the guest OSes too (e.g. in the devicetree
>>>> under /sys on Linux), which I hope is OK.
>>>
>>> Does adding a call to delete-fake-copyright in ciface_quiesce() as found
>>> in arch/ppc/qemu/methods.c help here?
>>
>> Not in Finnix, at least. Judging by the messages at bootup, the device-tree
>> is constructed before calling quiesce. I think this is kind of unavoidable
>> though.
>>
>> I would change 'fake copyright notice' to 'fake copyright property' in the
>> comments (both in go() and in qemu.fs), but anyway this seems good to me.
> 
> Great, thanks for the review! If there are no further comments, I'll
> commit this tomorrow.

It looks like there is a bit more discussion here, so I'll go ahead and
commit just the build fix (first patch in the series) for the moment.

I'll try and post an updated v2 soon based upon the feedback I've
received so far.


ATB,

Mark.