[OpenBIOS] [PATCH 4/5] pci: enable AAPL, address property for all Apple PPC machines

[Mark Cave-Ayland]

On 02/01/16 22:41, BALATON Zoltan wrote:

> On Sat, 2 Jan 2016, Mark Cave-Ayland wrote:
>> The property appears in device trees for both Old World and New World
>> Macs
>> so let's do the same.
>>
>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
>> ---
>> openbios-devel/drivers/pci.c |    5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/openbios-devel/drivers/pci.c b/openbios-devel/drivers/pci.c
>> index 45e954b..65f5fe9 100644
>> --- a/openbios-devel/drivers/pci.c
>> +++ b/openbios-devel/drivers/pci.c
>> @@ -1017,7 +1017,10 @@ static void ob_pci_add_properties(phandle_t
>> phandle,
>>     }
>>
>>     pci_set_assigned_addresses(phandle, config, num_bars);
>> -    OLDWORLD(pci_set_AAPL_address(config));
>> +
>> +    if (is_apple()) {
>> +        OLDWORLD(pci_set_AAPL_address(config));
> 
> The commit message suggests you intend to add it to New World machines
> too but it is still enclosed in OLDWORLD() after this patch. Is that
> correct? I think you wanted to replace OLDWORLD() with if(is_apple()).

Ah yes, and in fact the fix is to remove the surrounding OLDWORLD()
macro completely. Thanks for the review - I don't suppose it makes any
difference to MorphOS at all?


ATB,

Mark.