[openfirmware] [commit] r2359 - cpu/x86/pc/olpc/via

repository service svn at openfirmware.info
Thu Jul 14 05:58:52 CEST 2011


Author: wmb
Date: Thu Jul 14 05:58:52 2011
New Revision: 2359
URL: http://tracker.coreboot.org/trac/openfirmware/changeset/2359

Log:
OLPC manufacturing tests - fixed mfg-test-dev to correctly pass in device-specifier arguments, thus fixing a bug that caused "test int:0" to fail when the SD card did not have a partition table.

Modified:
   cpu/x86/pc/olpc/via/mfgtest.fth

Modified: cpu/x86/pc/olpc/via/mfgtest.fth
==============================================================================
--- cpu/x86/pc/olpc/via/mfgtest.fth	Thu Jul 14 05:49:29 2011	(r2358)
+++ cpu/x86/pc/olpc/via/mfgtest.fth	Thu Jul 14 05:58:52 2011	(r2359)
@@ -34,18 +34,21 @@
 
 : mfg-test-dev  ( $ -- )
    restore-scroller
-   ??cr  ." Testing " 2dup type cr
-   locate-device  if  ." Can't find device node" cr  exit  then  ( phandle )
-   " selftest" rot execute-phandle-method            ( return abort? )
-   if
-      ?dup  if
+   ??cr  ." Testing " 2dup type cr                     ( $ )
+   2dup locate-device  if                              ( $ )
+      2drop ." Can't find device node" cr  exit        ( -- )
+   else
+      drop                                             ( $ )
+   then                                                ( $ phandle )
+   " selftest" execute-device-method  if               ( return-code )
+      ?dup  if                                         ( return-code )
          ??cr ." Selftest failed. Return code = " .d cr
          mfg-color-red sq-border!
          false to pass?
          red-screen
          flush-keyboard
          mfg-wait-return
-      else
+      else                                                   ( )
          green-letters
          ." Okay" cr
          black-letters



More information about the openfirmware mailing list